Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert activity type mapping to log-scale. #272

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Convert activity type mapping to log-scale. #272

merged 3 commits into from
Dec 9, 2024

Conversation

beasleyjonm
Copy link
Contributor

The activity and potency types on Drug Central are log-scaled, so let's add the "p" in front of the activity types to reflect that.

@beasleyjonm
Convert activity type mapping to log-scale.
896e7af 
The activity and potency types on Drug Central are log-scaled, so let's add the "p" in front of the activity types to reflect that.
@beasleyjonm beasleyjonm added the Biological Context QC Require validation of biological context to ensure accuracy and consistency label Nov 24, 2024
@EvanDietzMorris
Copy link
Contributor

Let's discuss this in a meeting perhaps, but these mappings correspond to the values in the drugcentral database, so we can't just change them or it will break them all. Also, the output of using these mappings are the predicates, not the values like ic50, so if we want this change to be represented in the graph we'll need to do something else.

It also looks like this only alters the comment in the drug central parser, and the actual mappings are in predicates.py

@beasleyjonm
Copy link
Contributor Author

Ah, my mistake. I believe my latest commit fixes the issue correctly. Let's discuss in an upcoming meeting.

eKathleenCarter
eKathleenCarter reviewed Nov 26, 2024
View reviewed changes
parsers/drugcentral/src/loaddrugcentral.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eKathleenCarter check to confirm this. Can we make this biolink compliant?

@EvanDietzMorris
Copy link
Contributor

This code looks right now. As Kathleen comments, I think this would be a great example of a property that we would really like to be biolink compliant. Last time I looked I didn't see anything in the model that's an obvious fit, but maybe that's changed. Otherwise, we should reach out to the biolink folks and see if we can make a new property.

@EvanDietzMorris
Copy link
Contributor

I went ahead and switched the other parsers with these edge properties to using the constants we set up, so that they're all consistent. As well as adding this kind of property to biolink, we should probably audit the usage of them across the parsers to make sure they're used in the same way. (BINDING-DB, PHAROS, drugcentral, GtoPDB)

@EvanDietzMorris
Copy link
Contributor

Otherwise, I think we can go ahead and merge this in if you are both good with the state of it now.

eKathleenCarter
eKathleenCarter approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@eKathleenCarter eKathleenCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. we will follow up about making this biolink

@EvanDietzMorris EvanDietzMorris merged commit fcf6611 into master Dec 9, 2024
1 check passed
@EvanDietzMorris EvanDietzMorris deleted the drugcentral-logscale-potencies branch December 9, 2024 21:09
EvanDietzMorris added a commit that referenced this pull request Dec 19, 2024
@EvanDietzMorris
Squashed commit of the following:
40bbb95 
commit 502581d
Merge: 37ce60f 713f527
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Mon Dec 9 16:09:17 2024 -0500

    Merge pull request #265 from RobokopU24/add_GHaction

    Added a GitHub action...

commit 37ce60f
Merge: cd9a6c5 90c6231
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Mon Dec 9 16:07:41 2024 -0500

    Merge pull request #242 from RobokopU24/DnlRKorn-patch-4

    Fixed regex pattern issue in loadCTD.py

commit cd9a6c5
Merge: fcf6611 d63d4bb
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Mon Dec 9 16:04:50 2024 -0500

    Merge pull request #240 from RobokopU24/DnlRKorn-patch-2

    Dynamically load latest version of GenomeAlliance data

commit fcf6611
Merge: 43874d9 2a39e3a
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Mon Dec 9 16:00:09 2024 -0500

    Merge pull request #272 from RobokopU24/drugcentral-logscale-potencies

    Convert activity type mapping to log-scale.

commit 2a39e3a
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Tue Dec 3 12:18:36 2024 -0500

    making all instances of affinity/affinity parameter use the constants

commit 43874d9
Merge: 1867684 3491e3f
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Mon Dec 2 11:53:28 2024 -0500

    Merge pull request #267 from RobokopU24/LINCS

    Lincs

commit 3491e3f
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Mon Dec 2 11:51:21 2024 -0500

    fixing parser see commit description

    fixing several bugs and broken variable names
    - fixing source data download location
    - source data delimiter is comma not tab
    - cleaning up properties (they need to be a dictionary, but node props were unnecessary anyway)

    simplifying/fixing qualifier handling
    - using predicates like RO:0002212 includes directionality and will normalize to qualified version, old implementation didn't work anyway, so this is better

commit d2bead1
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Mon Dec 2 11:46:07 2024 -0500

    fixing missing comma, making quote usage consistent

commit 46f8117
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Tue Nov 26 10:56:15 2024 -0500

    general clean up, fixing imports, removing template comments

commit bc1e533
Author: beasleyjonm <85600465+beasleyjonm@users.noreply.github.com>
Date:   Mon Nov 25 16:38:44 2024 -0500

    Changed how activity parameters are described in log-scale.

commit 896e7af
Author: beasleyjonm <85600465+beasleyjonm@users.noreply.github.com>
Date:   Sat Nov 23 21:03:48 2024 -0500

    Convert activity type mapping to log-scale.

    The activity and potency types on Drug Central are log-scaled, so let's add the "p" in front of the activity types to reflect that.

commit 1867684
Merge: 52149ee 224d0b5
Author: beasleyjonm <85600465+beasleyjonm@users.noreply.github.com>
Date:   Thu Nov 21 12:19:08 2024 -0500

    Merge pull request #260 from RobokopU24/Issue257

    Add in all Monarch KG edge properties on ingest.

commit 52149ee
Merge: 6b8f389 7bbdc00
Author: beasleyjonm <85600465+beasleyjonm@users.noreply.github.com>
Date:   Thu Nov 21 12:14:21 2024 -0500

    Merge pull request #268 from RobokopU24/collapsed_qualifiers_kg

    Collapsed qualifiers kg

commit 7bbdc00
Author: beasleyjonm <85600465+beasleyjonm@users.noreply.github.com>
Date:   Thu Nov 7 12:35:08 2024 -0500

    Update collapse_qualifiers.py

commit 0839bcc
Author: Jon-Michael Beasley <jmb@JonMichaelsMBP.lan>
Date:   Thu Oct 31 13:42:46 2024 -0400

    Updated to fix code and add option to create collapsed qualifier Neo4j dump.

commit 0abf23c
Author: Jon-Michael Beasley <jmb@JonMichaelsMBP.lan>
Date:   Thu Oct 31 11:30:51 2024 -0400

    Added script to collapse object qualifier statements to the edge predicates.

commit 56e8b5b
Author: James Chung <jchung@renci.org>
Date:   Thu Oct 31 08:14:15 2024 -0400

    return variable added

commit af3037a
Author: James Chung <jchung@renci.org>
Date:   Wed Oct 30 23:35:18 2024 -0400

    LINCS parsers first try

commit b2eef57
Author: James Chung <jchung@renci.org>
Date:   Wed Oct 30 23:34:52 2024 -0400

    LINCS parser first try

commit 713f527
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Tue Oct 29 10:51:47 2024 -0400

    setting environment variable

commit 26b1073
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Tue Oct 29 10:34:55 2024 -0400

    trying again with fresh eyes

commit 99fc5ee
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Tue Oct 29 10:29:49 2024 -0400

    trying again with fresh eyes

commit cc587c2
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Tue Oct 29 10:18:03 2024 -0400

    trying again with fresh eyes

commit 689d6e9
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Tue Oct 29 10:02:14 2024 -0400

    new script for action

commit ff79e6a
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Tue Oct 29 09:58:35 2024 -0400

    trying again with gresh eyes

commit 91d695e
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 17:23:43 2024 -0400

    error tracking/loggins

commit 7423a00
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 17:20:02 2024 -0400

    gitHub issues error

commit 24d3c91
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 17:16:19 2024 -0400

    split pull requests and issues

commit 736d185
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:58:49 2024 -0400

    split pull requests and issues

commit 55be1e5
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:50:50 2024 -0400

    lets try this with github-script@v6 instead...

commit 76bc6bb
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:44:57 2024 -0400

    fix double/single quote issue

commit 745d0c3
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:43:27 2024 -0400

    fix double/single quote issue

commit e887346
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:22:29 2024 -0400

    fix double/single quote issue

commit 979bc72
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:19:08 2024 -0400

    bump

commit ff0fc91
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:15:29 2024 -0400

    bump

commit 2ff1393
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:14:13 2024 -0400

    actually invoke python...

commit 3e95ae8
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:10:24 2024 -0400

    update to the latest versions of checkout and setup-python

commit e528db4
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:04:06 2024 -0400

    bump

commit 56e9918
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 15:01:21 2024 -0400

    Update requirements.txt

    Will need PyGithub for this...

commit 0d62da8
Author: Kathleen Carter <163005214+eKathleenCarter@users.noreply.github.com>
Date:   Mon Oct 28 14:51:45 2024 -0400

    Added a GitHub action to automatically add the label "Biological Context QC" to issues and PRs that mention "predicate" or "biolink:"

    Automatically assign this event to Kathleen

commit 6b8f389
Merge: b5fcc32 f604791
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Thu Oct 24 15:40:23 2024 -0400

    Merge pull request #263 from RobokopU24/hgnc_fix

    updating HGNC file location and version date for new HGNC set up

commit f604791
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Thu Oct 24 13:23:43 2024 -0400

    updating HGNC file location and version date for new HGNC set up

commit b5fcc32
Merge: bc28a73 ff3099e
Author: Evan Morris <evandietzmorris@gmail.com>
Date:   Thu Oct 24 13:06:41 2024 -0400

    Merge pull request #262 from RobokopU24/dependabot/pip/mysql-connector-python-9.1.0

    Bump mysql-connector-python from 8.4.0 to 9.1.0

commit ff3099e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Oct 24 17:01:59 2024 +0000

    Bump mysql-connector-python from 8.4.0 to 9.1.0

    Bumps [mysql-connector-python](https://github.com/mysql/mysql-connector-python) from 8.4.0 to 9.1.0.
    - [Changelog](https://github.com/mysql/mysql-connector-python/blob/trunk/CHANGES.txt)
    - [Commits](mysql/mysql-connector-python@8.4.0...9.1.0)

    ---
    updated-dependencies:
    - dependency-name: mysql-connector-python
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit 224d0b5
Author: Daniel Korn <dkorn@ht1.cluster>
Date:   Thu Sep 19 15:29:18 2024 -0400

    Added all available metadata present in Monarch KG to edge properties.

commit 5e9151b
Author: Daniel Korn <dkorn@ht1.cluster>
Date:   Thu Sep 19 13:03:18 2024 -0400

    Changed Monarch KG ingest to automatically pull from the latest version. Also made process to check the metadata yaml file for the publishing date of the latest version.

commit 90c6231
Author: DnlRKorn <6885702+DnlRKorn@users.noreply.github.com>
Date:   Thu Jul 25 13:57:52 2024 -0400

    Fixed regex pattern issue in loadCTD.py

    Made the regex pattern a "raw" string.

commit d63d4bb
Author: DnlRKorn <6885702+DnlRKorn@users.noreply.github.com>
Date:   Thu Jul 25 11:48:15 2024 -0400

    Dynamically load latest version of GenomeAlliance data

    Previously genome alliance data was frozen to version 5.3.0; added some code to get the latest version instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eKathleenCarter eKathleenCarter eKathleenCarter approved these changes

Assignees
No one assigned
Labels
Biological Context QC Require validation of biological context to ensure accuracy and consistency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beasleyjonm @EvanDietzMorris @eKathleenCarter