Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version information to windows binary #36

Closed
dkrutsko opened this issue Aug 28, 2017 · 0 comments
Closed

Add version information to windows binary #36

dkrutsko opened this issue Aug 28, 2017 · 0 comments
Labels
Request A cool feature request for the library Win Relating specifically to Windows
Milestone
Robot-js 2.0.0

Comments

@dkrutsko
Copy link
Member

Windows supports the ability to compile version information as part of DLLs and executables. Since native Node modules are simple DLL files, version information could be included as part of the distribution. This would make identifying versions of modules simpler. The language neutral version information would include:

ProductName      = robot-js
FileVersion      = x.x.x.[modules_version]
RobotVersion     = x.x.x.0
CompanyName      = Robot Developers
OriginalFilename = [platform]-[arch]-[modules_version].node
@dkrutsko dkrutsko added the Request A cool feature request for the library label Aug 28, 2017
@dkrutsko dkrutsko added this to the Robot-js 2.0.0 milestone Aug 28, 2017
@dkrutsko dkrutsko mentioned this issue Sep 3, 2017
Closed
dkrutsko added a commit that referenced this issue Sep 3, 2017
@dkrutsko
Project reorganization (#35, fixes #2, #4, #32, #36, #37)
b45a7f2
@dkrutsko dkrutsko closed this as completed Sep 3, 2017
@dkrutsko dkrutsko added the Win Relating specifically to Windows label Mar 18, 2018
dkrutsko added a commit that referenced this issue Mar 25, 2018
@dkrutsko
Synchronizing version 2.0.0 (#55, fixes #17)
63a008a 
* Added newlines to some files
* Updated gitignore file
* Update copyright headers (#18, fixes #15)
* Added support for Node ^7.0.0 (#14, fixes #5, #16)
* Updated README file (#19, fixes #13)
* Fetch prebuilt binaries securely
* Added NPM and Yarn lock files (#30, fixes #28)
* Project reorganization (#35, fixes #2, #4, #32, #36, #37)
* Quotes
* Improvements to Windows RC
* Update copyright headers (#44, fixes #43)
* Updated lock files
* Removed visual studio toolset definitions (#47, fixes #46)
* Improved the install script (#48, fixes #38)
* Updated lock files
* Copy PDB files during compilation (#51, fixes #50)
* Updated version numbers (#52, fixes #17)
* Copy PDB files during compilation (#53, fixes #50)
* Version updates
* Fixed small bug in test case
* Updated lock files
* Minor fixes to get ARM to compile (#54, fixes #25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Request A cool feature request for the library Win Relating specifically to Windows
Milestone
Robot-js 2.0.0
Development

No branches or pull requests
1 participant
@dkrutsko