-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json: Archive size of v3.4.0 is 110MB #10000
Comments
For the record, today I spent 15 minutes downloading json. This is despite the fact that speedtest.net reported download speeds from my computer at 500 Mbps. If the server is being slow, then the 110 Mb is punishing. |
Well, the Drake mirrors don't have json v3.4.0 cached yet, so I guess for you github.com was slow today. More of a #8595 automation problem than a large file problem -- @jamiesnape FYI. |
As much as I would like to be the solution to all slower downloads, the mirrors aren't going to help much unless we make them the primaries, and the download for JSON has always been large (it grew about 800 KB between versions), so not sure why it is now such an issue. And yes, it is mirrored, though CloudFront does need to propagate the packages to its edges. |
Ah. I was thinking that Bazel tried all mirrors concurrently, but saying it out loud that would be silly. In any case, I wholeheartedly endorse closing this issue as "not even worth the time investment in discussing". |
Following endorsement; closing. |
FTR This is effectively captured by this issue (and its duplicates): |
FYI: nlohmann/json#96 is solved now and the next release will exclude test data and will be much smaller (~ 7 MB). |
Thank you! In the meantime, Drake has dropped its direct use of |
When building on my laptop at home, I noticed a large download for
json
, and just tried downloading the archive:Ends up, this is ~110MB compressed; uncompressed, a majority of the data resides in
/test
and/benchmark
, neither of which seem important to us. If you strip out/doc
as well, the resulting uncompressed files are 1.6MB.It'd be nice to get a version of the code that doesn't have that much uneeded bloat, but I don't know of any simple solutions aside from forking (yuck).
EDIT: Seems like they offer downloads, and there's an offering of
json.hpp
:https://github.com/nlohmann/json/releases/tag/v3.4.0
Will just switch to this.
\cc @jwnimmer-tri @jamiesnape
The text was updated successfully, but these errors were encountered: