Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should nuke almost certainly spurious "failure of target" caused by "running under Python 3" warning from Bazel. #14745

Closed
jamiesnape opened this issue Mar 8, 2021 · 4 comments · Fixed by #16259
Closed

Should nuke almost certainly spurious "failure of target" caused by "running under Python 3" warning from Bazel. #14745

jamiesnape opened this issue Mar 8, 2021 · 4 comments · Fixed by #16259
Assignees
@BetsyMcPhail
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: backlog unused team: kitware

Comments

@jamiesnape
Copy link
Contributor

jamiesnape commented Mar 8, 2021 •
edited
Loading

Specifically "The failure of target ..." may have been caused by the fact that it is running under Python 3 instead of Python 2. I fixed the issue in underactuated and manipulation, so I think it is a one-liner somewhere.

Relates #14739 (comment).

FYI @jwnimmer-tri @EricCousineau-TRI.
@jamiesnape jamiesnape added unused team: kitware priority: backlog component: build system Bazel, CMake, dependencies, memory checkers, linters labels Mar 8, 2021
@jamiesnape jamiesnape self-assigned this Mar 8, 2021
@jamiesnape
Copy link
Contributor Author

Russ's targets always explicitly set srcs_version = "PY3" and explicitly set python_version = "PY3" where appropriate.

@jamiesnape
Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI changed the title Nuke almost certainly spurious "failure of target" caused by "running under Python 3" warning from Bazel. Should nuke almost certainly spurious "failure of target" caused by "running under Python 3" warning from Bazel. Mar 8, 2021
@jwnimmer-tri jwnimmer-tri mentioned this issue Dec 20, 2021
Merged
@jwnimmer-tri
Copy link
Collaborator

I'm calling this good enough for now. I only fixed the drake_py_... targets. Any py_... targets from externals might still experience this warning, but shrug.

@jwnimmer-tri jwnimmer-tri mentioned this issue Jan 7, 2022
Merged
@jwnimmer-tri
Copy link
Collaborator

It turns out that mkdoc frequently spews about this as well, so I've done another PR (above) to fix that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BetsyMcPhail BetsyMcPhail

Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: backlog unused team: kitware
Projects
#dynamics-dev (Drake board)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tools] Set Python version to 3 explicitly jwnimmer-tri/drake
3 participants
@jamiesnape @BetsyMcPhail @jwnimmer-tri