Move many related Drake files into here #48
Conversation
jwnimmer-tri
added
the
status: commits are properly curated
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 21 of 21 files at r2, 10 of 10 files at r3, 18 of 18 files at r4, 1 of 1 files at r5, 4 of 5 files at r6, 1 of 3 files at r7, 3 of 3 files at r8, 6 of 6 files at r9, all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @jwnimmer-tri)
jwnimmer-tri
force-pushed
the
all-the-robots
branch
from
7ede868
to
285eddb
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
+@rpoyner-tri for feature review.
Reviewable status: all discussions resolved, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Reviewable status: all discussions resolved, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @rpoyner-tri)
ur3e line 1 at r10 (raw file):
ur_description/meshes
FYI #49
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 21 of 21 files at r2, 10 of 10 files at r3, 18 of 18 files at r4, 1 of 1 files at r5, 5 of 5 files at r6, 3 of 3 files at r7, 3 of 3 files at r8, 6 of 6 files at r9, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM from [rpoyner-tri] (waiting on @jwnimmer-tri)
iiwa_description/urdf/iiwa14.xacro line 42 at r2 (raw file):
<mesh filename="package://drake_models/iiwa_description/meshes/iiwa14/collision/link_0.obj"/> </geometry> <material name="Grey"/>
nit collision/material is dead code; i've generally been deleting it. Not sure why these didn't get caught. perhaps the if conditions didn't trigger, or something.
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, platform LGTM from [rpoyner-tri] (waiting on @jwnimmer-tri)
iiwa_description/urdf/iiwa14.xacro line 42 at r2 (raw file):
Previously, rpoyner-tri (Rick Poyner (rico)) wrote…
nit collision/material is dead code; i've generally been deleting it. Not sure why these didn't get caught. perhaps the if conditions didn't trigger, or something.
Since the goal here is just to move files, not fix bugs, I won't make any change here.
Probably the linter isn't catching this yet because this xacro is only used for documentation, it's not processed unto URDF files automatically.
There was a problem hiding this comment.
Reviewable status:
Copied from Drake as of e41e11f5. Both locations had a README.md, so here we concatenated the two.
Copied from Drake as of e41e11f5. The iiwa7 subdir nesting vanishes; all sdfs are in one place.
Copied from Drake as of e41e11f5. Both locations had a README.md, so here we concatenated the two.
Copied from Drake as of e41e11f5 from the ur3e directory. Here, we've renamed to ur_description for consistency with upstream.
Copied from Drake as of e41e11f5. Both locations had a README.md, so here we concatenated the two.
jwnimmer-tri
force-pushed
the
all-the-robots
branch
from
285eddb
to
6ca6e8f
Compare
|
Sigh. I forgot to wait for platform review on this PR. Our Reviewable interlock doesn't enforce it. |
Packages moved here:
Towards #44 and RobotLocomotion/drake#13942.
Twin PR: RobotLocomotion/drake#21218.
This change is