Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw TypeError when subclasses forget to call __init__ #44

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Throw TypeError when subclasses forget to call __init__ #44

merged 1 commit into from
Aug 3, 2020

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Aug 3, 2020 •
edited
Loading

Cherry-pick of pybind#2152

(Trying to do a full update in #43 was a bit too painful)

This change is Reviewable

EricCousineau-TRI
EricCousineau-TRI commented Aug 3, 2020
View reviewed changes
Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@RussTedrake for review, please!

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @RussTedrake)

RussTedrake
RussTedrake approved these changes Aug 3, 2020
View reviewed changes
Copy link

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM: class.h looks like a foreign language to me, but it’s from upstream, and the tests they add are clearly what I was hoping for. Thanks!

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

RussTedrake
RussTedrake approved these changes Aug 3, 2020
View reviewed changes
Copy link

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but it looks like travis CI is not happy)

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@EricCousineau-TRI
Copy link
Collaborator Author

I believe all failures are irrelevant here. From: https://travis-ci.com/github/RobotLocomotion/pybind11/builds/178206816

  • 221.10: Bad provisioning
  • 221.12: CPython 3.9 is still in beta
  • 221.13: PyPy 2.7 - two things we don't care about (PyPy CPython, 2.7 vs 3.x)
  • 221.14: PyPy 3.6 - also do not care about this one.

Merging!

CI itself should be made more stable once RobotLocomotion/drake#13800 is resolvedd

@EricCousineau-TRI EricCousineau-TRI merged commit 18dfca6 into RobotLocomotion:drake Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussTedrake RussTedrake RussTedrake approved these changes

Assignees

@RussTedrake RussTedrake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricCousineau-TRI @RussTedrake @virtuald