Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert the message metadata in JSON only for debug #1010

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

minggangw
Copy link
Member

Fix: #1007

@minggangw minggangw requested a review from Copilot December 10, 2024 08:49

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • package.json: Language not supported
  • rosidl_gen/generator.json: Language not supported
  • rosidl_gen/templates/message.dot: Language not supported
Comments skipped due to low confidence (1)

rosidl_gen/idl_generator.js:26

  • The behavior introduced by the isDebug variable should be covered by tests to ensure it works as expected.
const isDebug = !!process.argv.find((arg) => arg === '--debug');
@minggangw minggangw merged commit e69a22c into RobotWebTools:develop Dec 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't insert the message metadata generated by parser into JS messages for production
1 participant