Fix continuous map updates #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Revert Viewer shifting offsets before scaling -Added an example page to view continuous map updates
|
👍 Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Revert Viewer shifting offsets before scaling
-Added an example page to view continuous map updates
Started on issue #29, although nothing to do with the title.
Previous build would not revert the offset shift for map origin, causing the following scales and shifts to go out of control and map not showing any more, only black background. In order to revert the offset, the previous offset was saved in new viewer variables
viewer.x_prev_shiftandviewer.y_prev_shiftThis seems to be working for both continuous and one-time map updates. Someone with more experience could make the necessary adjustments in the code, most likely.