Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope Dashboard Record Type to only show record types of transfers for an organization #433

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

p-galligan
Copy link
Member

Adding a filter to record type data in views to only show in organization data. Fixes #408 .

adding a filter to record type data in views to only show in organization data.
@p-galligan
Copy link
Member Author

I tested this by creating a new org with no transfer, and then moving the donor user to the new organization. When on the new organization, no RecordTypeData was shown on the dashboard.

I believe this meets the requirements for #408 .

@p-galligan p-galligan changed the title add filter Scope Dashboard Record Type to only show record types of transfers for an organization Jun 12, 2020
@helrond
Copy link
Member

helrond commented Jun 12, 2020

I added a conditional so that record types with a zero count for an organization aren't shown in the legend.

Copy link
Member

@helrond helrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @p-galligan

@p-galligan
Copy link
Member Author

Thanks! I missed that.

@p-galligan p-galligan merged commit b52a134 into v2.1 Jun 12, 2020
@p-galligan p-galligan deleted the issue-408 branch June 12, 2020 14:12
@helrond helrond mentioned this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants