Reading room date picker

[chryslovelace]

This uses the endpoint added to request-broker in RockefellerArchiveCenter/request_broker#299 to get name and time information about available reading rooms from Aeon in order to ensure the user selects a valid time.

[chryslovelace]

As it stands, the code here doesn't allow for a way to bypass the Aeon API integration that pulls in the reading room data. Is that something you would want, and if so, how would you want that to be configured?

[helrond]

@chryslovelace Right now we don't want users to have to pick a Reading Room or a time in our implementation of DIMES, so yes, it's something I'd like to be able to turn off. So far we've put all configuration stuff in .env but I'm wondering if there are better solutions for this that you'd suggest?

[helrond]

Hi @chryslovelace - I'm gonna trust that the implementation for when you have reading rooms set up in Aeon works because we don't have that set up right now. HOWEVER I am seeing that the REACT_APP_ENABLE_READING_ROOM_SELECT is not working as expected, which I think is because that variable is being parsed as a string, not a boolean, so as long as it's present it evaluates to true. There are probably a number of ways to address this (only add the environment variable if you want to enable the reading room select, convert the string to a boolean, etc) but regardless of which you go with we should probably document this feature in the README.

[chryslovelace]

As suggested, I converted that env var to boolean where its used, so it'll be activated as long as the env var is present and is anything but the empty string. The build process seems to be getting stuck in some sort of loop.

[helrond]

HI @chryslovelace I am baffled by the behavior in CI. My only thought is that something about the fact that this PR is coming from a different GH organization is causing the Docker build to blow up. 🤷

I haven't fully tested the reading room functionality because we're not going to be using it in the immediate future so I'll just trust that it works for you. I've added a couple of really minor things here. If you don't mind taking care of those I'll try cloning the development branch in this repository to another branch, repoint this PR at that branch and merge. That should allow me to point at development and have CI pass. Sound good?