Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds link resolver to request broker API #184

Merged
merged 9 commits into from
Jul 7, 2022
Merged

Adds link resolver to request broker API #184

merged 9 commits into from
Jul 7, 2022

Conversation

kcloud
Copy link
Contributor

@kcloud kcloud commented Mar 11, 2022

No description provided.

@helrond
Copy link
Member

helrond commented Jul 7, 2022

OK I have:

  1. added a test for the LinkResolver view.
  2. pulled in the DIMES_HOSTNAME config (renamed from DIMES_PREFIX) in more places in the application.
  3. renamed the HOSTNAME setting to RESOLVER_HOSTNAME so its purpose is more apparent.

I did not create a test for the resolve_ref_id helper because it's relatively simple and the complexity required in mocking doesn't seem to match what we'd actually be able to test.

kcloud added a commit to ulsdevteam/request_broker that referenced this pull request Jul 7, 2022
@kcloud
Update settings for RockefellerArchiveCenter#184
f24d191
@helrond helrond merged commit 577bee3 into development Jul 7, 2022
@helrond helrond deleted the islandora_link_resolver branch July 7, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcloud @helrond