fix: a proposal to fix the admin user message flow #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlenDavid
reviewed
Oct 4, 2023
lib/PersistHelper.ts
Outdated
| const persistenceRead: IPersistenceRead = read.getPersistenceReader(); | ||
| const results = await persistenceRead.readByAssociations(associations) as Array<UserRegistrationModel>; | ||
|
|
||
| if (results === undefined || results === null || results.length == 0) { |
There was a problem hiding this comment.
Suggested change
| if (results === undefined || results === null || results.length == 0) { | |
| if (results == null || results.length == 0) { |
undefined == null is true
AlenDavid
reviewed
Oct 4, 2023
| @@ -1001,3 +1019,181 @@ export const retrieveLoginMessageSentStatus = async ({ | |||
|
|
|||
| return result[0].isLoginMessageSent; | |||
| }; | |||
|
|
|||
| type LastBridgedMessageInfo = { | |||
There was a problem hiding this comment.
for a 1000+ lines file please avoid defining types here, its better to import them
AlenDavid
suggested changes
Oct 4, 2023
| return result[0]; | ||
| }; | ||
|
|
||
| const simpleHash = (input: string): string => sha256(input).toString() |
| rocketChatUserId, | ||
| messageFootprint, | ||
| // source | ||
| }: { |
There was a problem hiding this comment.
please avoid adding types later as it increases the number of lines and complexity of the file.
lib/PersistHelper.ts
Outdated
| messageFootprint: string | ||
| persistence: IPersistence, | ||
| rocketChatUserId: string; | ||
| // source: 'rocket.chat' | 'msteams' |
| ), | ||
| ]; | ||
|
|
||
| return (await read.getPersistenceReader().readByAssociations(associations)).shift() as MessageFootprintInfo |
There was a problem hiding this comment.
in a promise, avoid return await expressions.
AlenDavid
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the messaging flow issue that occurs when the user who created the bridge sends a message to both Teams and Rocket.Chat. The following changes have been made to resolve the problem:
Modified the logic that prevented messages from admins being set as senders. Now, admin messages can be properly processed as senders.
Introduced a footprint mechanism to determine whether a message has already been sent based on its text, user, room, and file name. This ensures that duplicate messages are avoided.
Implemented a persistence feature to store information about sent messages. Before sending a message, the system checks the persistence records to prevent messaging loops between Rocket.Chat and Teams.