[FIX] loadOne doesn't fetch app data from database #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapiarafael
approved these changes
May 9, 2023
d-gubert
added a commit
that referenced
this pull request
May 11, 2023
d-gubert
added a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? ⛵
Added a new method
addLocalwhich is the correspondent version ofaddthat will load an app from the database and start it up.Why? 🤔
Previously the
loadOnemethod was used to load apps when an instance of Rocket.Chat received a notification that an app had been installed somewhere else in the cluster. However, due to changes to this method, it was actually breaking this flow. The new method is added to provide the lost functionalityLinks 🌎
PS 👀
Rocket.Chat PR with implementation: RocketChat/Rocket.Chat#29180