Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not post a new release with thousand of new critical errors #1778

Closed
mountstone opened this issue Oct 3, 2020 · 3 comments
Closed

Do not post a new release with thousand of new critical errors #1778

mountstone opened this issue Oct 3, 2020 · 3 comments

Comments

@mountstone
Copy link

mountstone commented Oct 3, 2020

It isn't hard to use v3.0.0-alpha/beta naming convention or sth, because every version you use seems to be treated as stable but it's not. You are pronuncing new version but it's just a pandora's box.

Consider to add more info in every version, e.g. wasn't tested well...

There are lot of companies which use open source msng tools, one of them is Rocket Chat, but there is no place to release software in that way just because it's open source and you don't take responsibility for it.

@ankar84
Copy link

ankar84 commented Oct 3, 2020

Partly I agree with @mountstone
3.0.0 should be some alpha version for enthusiasts only and for wide users amount should be available 3.0.2 or some other stable one version
@tassoevan we need alpha channel

@tassoevan
Copy link
Collaborator

tassoevan commented Oct 3, 2020

First of all, I want to let clear that I'm not going to make any excuses on how clunky and unprofessional my maintenance has been, specially after the "MacOS Catalina battle" and three months of development freeze due to a code signing certificate renewal nightmare. The following examples just illustrate why things happened the way they happened.

@ggazzo and I have agreed on not only making alpha releases as well doing some sort of dogfooding (we do it a lot for RC server).

The major blocker for it is our tooling: it's not hard to find comments from me in this repo talking about how unstable Electron API and electron-builder are. In fact, most of the rewrite for 3.x was made to address long-standing security issues coming from bad practices required by the framework in the near past. For instance, the current "invalid server" errors are result of our first attempt to match the client and the server without giving room for malicious instances abusing the preload script.

On the topic of building the app, a bug in electron-builder deployment to GitHub made us lose a day of work. Despite alpha and beta channels being available, it forces us to completely abandon the standard git-flow, merging everything in the master branch and tagging stable commits 1 - and we're already going for it. Ironically, our expectation is to release more often, almost continuously, under this workflow.

1 This is happening in our Fuselage monorepo too because Lerna isn't compliant to git-flow.

@gniezen
Copy link

gniezen commented Apr 1, 2021

@tassoevan Would you mind elaborating a bit on your workaround for the electron-builder "socket hang up" bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants