Error: Socket Hang up when electron-builder Release on github. #4940
Comments
|
Is this consistently reproducable? This seems like it could be related: request/request#2047 Have you tried upgrading your node version? |
|
@b-zurg |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Question - how long does the upload take? This sort of error is something I've encountered elsewhere on long uploads |
|
I am having the same today, never had this issue before: https://travis-ci.com/github/hovancik/stretchly/jobs/362382915 |
|
|
Does it happen repeatedly? Is it a one off thing? |
|
Well I tried like 10 times now and it seems always the same. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Keep this opened. |
|
Hello 🖖🏻 I am also facing this issue since some weeks ago. https://github.com/Graviton-Code-Editor/Graviton-App/runs/1140459243?check_suite_focus=true Notes:
|
|
Publishing is almost unusable. It is falling for me at a ratio of around one successful upload to five failed ones. |
|
I have experienced socket hang ups in different contexts when there is a long running upload. It depends on the specific connection being made and if the connection is not kept alive the upload target thinks it's a dead connection and kills it. That's what it seems like is happening here. The comments indicate that it does go through sometimes. I would bet that those times the upload happened just a bit faster. I'm also going to guess that is it's under 2 minutes it's fine as the default connection time out for node JS is 2 minutes. Could anyone verify these guesses? |
|
If I'm reading this right, there is no option to set a preferred timeout and it may fail four times before rejecting the upload. |
|
I've noticed something else: it doesn't fail at the times my draft release is empty, i.e., when there is no need to overwrite files. Looking at all the examples you folks posted here, they all are trying to overwrite files. Is it possible that a change in GitHub API is the root cause? |
You are absolutely right, it has only been randomly failing when I had a draft matching the same version. Now I have increased the version, it does no longer match the draft's version so it now doesn't randomly fail anymore |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Still relevant |
|
|
|
Can also confirm that this is still an issue, and yes, only occurs if the version tag already exists (i.e. it is overwriting a file).
|
|
same issue here, we are experiencing this error on-off for months :-( |
|
Same for me on a GH mac os runner. https://github.com/agrc/api-client/runs/3873267275?check_suite_focus=true |
|
I can reproduce it still, for parallel builds |
|
Happening to me too, trying to deploy on Windows and Ubuntu. Deleting the release so it does not try to overwrite fixes it for me. |
the latest versions won't replace an existing release file and fail with asset_already_exists electron-userland/electron-builder#3559 electron-userland/electron-builder#5148 electron-userland/electron-builder#4940
|
still have this happening multiple times today. https://github.com/lbry-foss/lbry-desktop/runs/4692765872?check_suite_focus=true#step:6:207 Is it a time-out we are hitting or?
|
If I recall correctly, this is from the github API, not the actual http client; Further, I had difficulties around this because of draft mode. Even after changing the release from draft mode, the issue remained. There is some lingering funk from draft mode, GH doesnt clean-up well there? |
|
If there is some error coming from the github api. Electron builder should handle those errors as well. Avoiding socket closed issue. Maybe we then also see what the root cause may be. Edit: it indeed only take place when overriding the existing file. |
|
I have these observations from trying to debug this locally:
electron-builder/packages/electron-publish/src/gitHubPublisher.ts Lines 200 to 202 in 00e49e4
I'll continue experimenting and debugging, and try and come up with a PR to fix at least this portion of these errors the description we get back is like: |
|
I've tried electron-builder v23.0.2, which has the fix in #6563 , but unfortunately this leads to a never-ending loop on CircleCI builds (but works fine on Appveyor): |
|
Upgrading from 22.14 -> 23.0 fixed this for me. Thanks! |
|
@mmaietta I think you may have closed this one in error. The fix works on Windows/Appveyor builds, but (at least for me) led to a never-ending loop on MacOS/CircleCI builds. |
|
I can confirm that for me the error still exists with Version 23.0.3. It randomly fails uploading to existing assets. After some reruns it works. |
|
This definitely still occurs in 23.0.3. |
|
😭 just found this thread - still happening |
|
Reopening. I'm going to need someone else to investigate this though as I have no idea where to debug this. |
|
GitHub's official actions/upload-artifact#116 (comment)
|
|
same problem at |
|
Any updates on this? |
|
Happy to review a PR contribution for this issue as I'm not able to devote any of my time to this ticket. |
|
Can you explain why? And unfortunately I am not able to fix this, I simply don’t know how. |
|
Not sure if this helps for your immediate problem @koningcool, but I have a workaround in place that simply deletes the release before running https://github.com/Deathspike/ulmas/blob/78b42f70e0c940e9731cc66fb87bdb09f687f160/.github/workflows/electron-snapshot.yml |
and others
Version: 22.6.0
Electron Version:8.1.1
Electron Type (current, beta, nightly):Current
My
electron-builder.jsonfile for configurationsWhen I run the command
npm run publish:githubthen the following error will occur after the final build and uploadingPlz, Help to solve my Issue.
The text was updated successfully, but these errors were encountered: