Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Show account status in menu bar #759

Merged
merged 1 commit into from
Jul 4, 2018

Conversation

HappyTobi
Copy link
Contributor

@HappyTobi HappyTobi commented Jul 3, 2018

Add new feature to show account status in menu bar
(implemented for all OS - actually there now special icons for windows and linux)

Feature Request
Server Changes to activate function

Short video about the new feature
video

@gdelavald
Copy link
Contributor

Looks awesome! Thanks for your contribution. I will wait for the server side PR to be merged before releasing this, but it should be soon.

@gdelavald gdelavald merged commit d52dc12 into RocketChat:develop Jul 4, 2018
@HappyTobi
Copy link
Contributor Author

Thx

@jwallet
Copy link
Contributor

jwallet commented Jul 9, 2018

seems like notification does not work anymore on windows after this pr

@HappyTobi
Copy link
Contributor Author

HappyTobi commented Jul 10, 2018

I will Check that in the evening today and fix the issue.
I will also create some status icons for windows and linux

@jwallet
Copy link
Contributor

jwallet commented Jul 10, 2018

im thinking about adding next to the status dot that you added ,a way to show that there is new activity without breaking the appearance of rocket.chat logo, something like how Slack does it for the tray icon, a blue dot (alert) and a red one (mentions) and when you hover the "Rocket.Chat+" title will change for "24 unread messages".

i will probably change those pics anyway but keeping the feature you added, the icon will just be the default tray_icon with the status dot next to it. but having all named files you created for osx would be nice.. there is no sign of these in the repo

@HappyTobi
Copy link
Contributor Author

HappyTobi commented Jul 11, 2018

so i fixed the problem with the default tray_icon. Fix

There some differences between the platforms while showing the tray icons and status.

OS X:

  • use the template icon's and an title tag to give you some information (the title will be uses to visualize the user state)
  • there no special icons to show badge state because of the dock implementation.
  • There is only one icon to show badge state (rocket with exclamation mark)

Windows / Linux:

  • uses special icons for each badge state (1-9+)
  • to show the user state we have to create some special icons (open)

@ccfiel
Copy link

ccfiel commented Oct 26, 2018

In version 14.1 this does not work in linux ( ubuntu 16.04)

@ttepatti
Copy link

This also does not work for me on Linux (Debian 9.5 w/ Gnome 3.22.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants