Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Status Icons #2714

Closed
wants to merge 7 commits into from
Closed

[NEW] Status Icons #2714

wants to merge 7 commits into from

Conversation

djorkaeffalexandre
Copy link
Collaborator

Proposed changes

Implement the new status icons including the loading status state.

Issue(s)

How to test or reproduce

  • Check if the loading status is working fine by opening the app.
  • Check all places that uses the Status Component.

Screenshots

Screen Shot 2020-12-15 at 12 48 32 PM
Screen Shot 2020-12-15 at 12 45 49 PM

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes

Further comments

@diegolmello
Copy link
Member

Closed in favor of #2991

@diegolmello diegolmello deleted the new.status-icon branch March 18, 2021 18:06
@diegolmello
Copy link
Member

@djorkaeffalexandre Thank you for your contribution! 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🎉 feature 👀 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djorkaeffalexandre @diegolmello