Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Webview not falling back to default auth challenge when no cert is provided #2918

Merged
merged 6 commits into from
Feb 22, 2021
Merged

[FIX] Webview not falling back to default auth challenge when no cert is provided #2918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e60c32b
[FIX] Android - fallback to default auth challenge handling when no c…
newmanw Feb 18, 2021
40c1496
No client certificate case defaults to super implementation
newmanw Feb 18, 2021
e74e37a
Merge branch 'develop' into fix.android-auth-challenge
diegolmello Feb 18, 2021
46f3780
Update react-native-webview
gerzonc Feb 19, 2021
3a8e66d
Merge branch 'develop' into fix.android-auth-challenge
gerzonc Feb 19, 2021
a2ccc18
Downgrade to previous dependency version
gerzonc Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions patches/react-native-webview+10.3.2.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java b/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java
index ab869cf..2aa7a9e 100644
index ab869cf..08ce7ce 100644
--- a/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java
+++ b/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java
@@ -84,6 +84,12 @@ import java.util.Map;
Expand Down Expand Up @@ -44,7 +44,7 @@ index ab869cf..2aa7a9e 100644
}

@Override
@@ -742,12 +754,54 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {
@@ -742,12 +754,56 @@ public class RNCWebViewManager extends SimpleViewManager<WebView> {

protected static class RNCWebViewClient extends WebViewClient {

Expand Down Expand Up @@ -93,6 +93,8 @@ index ab869cf..2aa7a9e 100644
+ }
+ };
+ task.execute();
+ } else {
+ super.onReceivedClientCertRequest(view, request);
+ }
+ }
+
Expand Down
4 changes: 1 addition & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13189,7 +13189,7 @@ react-native-windows@^0.62.0-0:
uuid "^3.3.2"
xml-parser "^1.2.1"

react-native@RocketChat/react-native#0.63.4, react-native@^0.63.1:
react-native@RocketChat/react-native#0.63.4:
version "0.63.4"
resolved "https://codeload.github.com/RocketChat/react-native/tar.gz/616299bbc01eeb56cb7d5b52e543051e1ad2d136"
dependencies:
Expand Down Expand Up @@ -13832,8 +13832,6 @@ ripemd160@^2.0.0, ripemd160@^2.0.1:
rn-extensions-share@RocketChat/rn-extensions-share:
version "2.4.1"
resolved "https://codeload.github.com/RocketChat/rn-extensions-share/tar.gz/4d7c0e4c2f300e4fb116af7b7cc0dbbc8169150c"
dependencies:
react-native "^0.63.1"

rn-fetch-blob@0.12.0:
version "0.12.0"
Expand Down