Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Unarchive permission not honored #3237

Merged
merged 10 commits into from
Aug 16, 2021
Merged

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Jun 23, 2021

Proposed changes

Implemented to show an alert error when archive/unarchives a room.
Disable the ARCHIVE/UNARCHIVE button due to the role permission

Issue(s)

#3118
I archive the channel, the "Unarchive" button appears, but it does not work

How to test or reproduce

  • Go to a Room (channel, dm, discussion)
  • Click on Title
  • At Actions screen, click on title
  • And needs to appear the Edit button, then click on it
  • Go to Room Info Edit
  • Archive the room
  • Unarchive the room
  • If the button for Archive/Unarchive is blocked, it's because the user doesn't have permission to do that thing

Screenshots

Before After

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Closes #3118

app/views/RoomInfoEditView/index.js Outdated Show resolved Hide resolved
@diegolmello diegolmello changed the title [FIX] Unarchive rooms showing alert error and disable due the permissions [FIX] Unarchive permission not honored Jul 22, 2021
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few changes and now lgtm.
@reinaldonetof Can you add a proper test plan and update the description?

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2021

CLA assistant check
All committers have signed the CLA.

@diegolmello diegolmello merged commit 1c43c78 into develop Aug 16, 2021
@diegolmello diegolmello deleted the fix.unarchive-rooms branch August 16, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function "Unarchive" the channel does not work
4 participants