-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Hardcoded backdrop opacity on loading component #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolmello
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reinaldonetof I made some changes on 08ccb7d
Can you re-review and make sure I didn't break anything?
Run StatusView tests from detox pls.
Leaving approve anyways.
Thanks.
diegolmello
changed the title
[FIX] Backdrop opacity theme applied on Loading component
[FIX] Hardcoded backdrop opacity on loading component
Jul 22, 2021
@reinaldonetof Also can you write a proper test plan (testing themes)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Apply backdrop opacity theme on Loading component. In addition, added a quick animation to show the backdrop opacity.
Issue(s)
Backdrop opacity was fixed for the Light and Dark theme
How to test or reproduce
The best way to test this task is
permalink
from that messageScreenshots
Types of changes
Checklist
Further comments