Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Hardcoded backdrop opacity on loading component #3255

Merged
merged 10 commits into from
Aug 16, 2021

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Jul 6, 2021

Proposed changes

Apply backdrop opacity theme on Loading component. In addition, added a quick animation to show the backdrop opacity.

Issue(s)

Backdrop opacity was fixed for the Light and Dark theme

How to test or reproduce

The best way to test this task is

  • Go to a channel
  • Write a message
  • Get the permalink from that message
  • Paste it and send
  • Then, when click on the link will appear the Loading

Screenshots

Before After

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Jul 16, 2021
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reinaldonetof I made some changes on 08ccb7d
Can you re-review and make sure I didn't break anything?
Run StatusView tests from detox pls.
Leaving approve anyways.
Thanks.

@diegolmello diegolmello changed the title [FIX] Backdrop opacity theme applied on Loading component [FIX] Hardcoded backdrop opacity on loading component Jul 22, 2021
@diegolmello
Copy link
Member

@reinaldonetof Also can you write a proper test plan (testing themes)?

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2021

CLA assistant check
All committers have signed the CLA.

@diegolmello diegolmello merged commit 14fd12c into develop Aug 16, 2021
@diegolmello diegolmello deleted the fix.backdrop-opacity-loading-animated branch August 16, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants