Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] The unread section is not removed after receiving a new message and swipe to read #3281

Merged
merged 8 commits into from
Aug 27, 2021

Conversation

reinaldonetof
Copy link
Contributor

Proposed changes

Currently, when the user is sorting the chat list by Unread on top and there is an Unread Chat that contains a direct message or a message in a thread to read, then, if the user swipe to the right and press "read", the list isn't re-render.

Issue(s)

The "unread on top" setting is enabled. I receive a new message.
The unread section appears.
Swipe right and "read".
The new message icon was removed, but the unread section was NOT removed.

#3258

How to test or reproduce

  • The "unread on top" setting is enabled.
  • receive a new message.
  • The unread section appears.
  • Swipe right and "read".
  • The list is re-render

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Closes #3258

@lgtm-com
Copy link

lgtm-com bot commented Jul 16, 2021

This pull request introduces 1 alert when merging 7ca2c3c into d1f35bb - view on LGTM.com

new alerts:

  • 1 for Off-by-one comparison against length

@diegolmello diegolmello changed the title [FIX] The unread section is not removed after receiving a new message and swipe to the right and "read". [FIX] The unread section is not removed after receiving a new message and swipe to read Aug 27, 2021
@diegolmello diegolmello merged commit 8b35f5c into develop Aug 27, 2021
@diegolmello diegolmello deleted the fix.unread-section-not-change-when-read branch August 27, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The unread section is not removed after receiving a new message and swipe to the right and "read".
2 participants