Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Omnichannel custom fields are not rendered properly #3295

Merged
merged 9 commits into from
Aug 23, 2021

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Jul 24, 2021

Proposed changes

Fix the labels and values within the custom fields

Depends on #3294

Issue(s)

App crashes when trying to save
Also, the Edit Room form is not deal well with all types of fields, as you can see below([Object Object], check promotion custom field configuration on Multiverse server)

How to test or reproduce

1 - Activate Omnicahnnel -> https://docs.rocket.chat/guides/omnichannel-guides/omnichannel-admins-guide
2 - Go to Omnichannel Custom Fields (Enterprise edition)
3 - Create a new custom field
4 - Start a new chat through Livechat
5 - Go to Omnichannel Queue (Mobile)
6 - Open an incoming chat
7 - Go to Room info panel
8 - Edit Room
9 - Change custom field value
10- Save Room

Screenshots

Before After

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@AlexAlexandre AlexAlexandre self-requested a review August 2, 2021 20:35
Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 77f2960 into develop Aug 23, 2021
@diegolmello diegolmello deleted the fix.omnichannel-custom-fields branch August 23, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants