Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Fetch members from API endpoint #3351

Merged
merged 11 commits into from
Sep 16, 2021

Conversation

gerzonc
Copy link
Contributor

@gerzonc gerzonc commented Aug 26, 2021

Proposed changes

Currently we've been using a method call for fetching members, on RoomMembersView, but we should use REST API like the Web client does.

Issue(s)

How to test or reproduce

In order to test this you should create a group, direct message with multiple users or team, and server version being at least 3.16.0

  1. Go to a room
  2. Tap on room's title
  3. Tap on Members

It should render the members that are online from that room

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@gerzonc gerzonc self-assigned this Aug 26, 2021
@gerzonc gerzonc marked this pull request as ready for review September 1, 2021 17:18
@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2021

This pull request introduces 1 alert when merging 4eeb478 into 2c31fc2 - view on LGTM.com

new alerts:

  • 1 for Potentially inconsistent state update

app/lib/rocketchat.js Outdated Show resolved Hide resolved
app/lib/rocketchat.js Outdated Show resolved Hide resolved
app/lib/rocketchat.js Outdated Show resolved Hide resolved
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diegolmello diegolmello changed the title [NEW] Fetch members from API endpoint [IMPROVE] Fetch members from API endpoint Sep 16, 2021
@diegolmello diegolmello merged commit 4f241b3 into develop Sep 16, 2021
@diegolmello diegolmello deleted the new.fetch-members-rest-api branch September 16, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants