Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Migrate AutoTranslateView to Typescript #3380

Merged
merged 5 commits into from
Sep 15, 2021

Conversation

AlexAlexandre
Copy link
Contributor

Proposed changes

The purpose of this PR it is migrate the view AutoTranslateView to typescript

Issue(s)

N/A

How to test or reproduce

You can test the code running yarn lint or prettier-lint to check the code style too.

Screenshots

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diegolmello diegolmello changed the title Migrating the view AutoTranslateView to typescript Chore: Migrate AutoTranslateView to Typescript Sep 15, 2021
@diegolmello diegolmello merged commit 212d7ba into develop Sep 15, 2021
@diegolmello diegolmello deleted the improvement.ts-migration.view.AutoTranslateView branch September 15, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants