Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: @rocketchat/sdk not fetching correct commit #3384

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Sep 15, 2021

Proposed changes

We pointed @rocketchat/sdk to the latest commit on #3279, but it'd not fetch the correct version automatically.
As that's not enough, we bumped it to 1.1.0.

Issue(s)

https://app.clickup.com/t/de44ww

How to test or reproduce

  • Checkout this branch
  • yarn
  • yarn lint
  • No issues

Prior to this, yarn lint would result in Typescript errors on the SDK.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@AlexAlexandre AlexAlexandre self-requested a review September 15, 2021 14:54
Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT :)

@diegolmello diegolmello merged commit 9ed6a3e into develop Sep 15, 2021
@diegolmello diegolmello deleted the fix.js-sdk-yarn branch September 15, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants