Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update WatermelonDB to 0.23.0 #3386

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Sep 16, 2021

Proposed changes

Updates @nozbe/watermelondb to 0.23.0.
After this PR lands, we can make use of JSI.

Issue(s)

https://app.clickup.com/t/5n4v60

How to test or reproduce

  • Test general features that involves local database: channels, messages, close and resume the app, etc
  • Notifications should be working properly

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello marked this pull request as ready for review October 1, 2021 20:34
@diegolmello diegolmello merged commit 8de6adc into develop Oct 1, 2021
@diegolmello diegolmello deleted the update-watermelon-23 branch October 1, 2021 20:35
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant