Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Migrate LoginView to TypeScript #3423

Merged
merged 15 commits into from
Oct 20, 2021
Merged

Chore: Migrate LoginView to TypeScript #3423

merged 15 commits into from
Oct 20, 2021

Conversation

gerzonc
Copy link
Contributor

@gerzonc gerzonc commented Oct 4, 2021 •
edited
Loading

Proposed changes

Migrates LoginView to TypeScript

Issue(s)

How to test or reproduce

On Login:

  1. Check that each input is working properly
  2. Check that buttons are working properly
  3. Check that login actions are working properly (oauth and simple login)

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@gerzonc gerzonc self-assigned this Oct 4, 2021
@gerzonc gerzonc marked this pull request as ready for review October 4, 2021 19:40
@gerzonc gerzonc changed the title [CHORE] Migrate LoginView to TypeScript Chore: Migrate LoginView to TypeScript Oct 5, 2021
AlexAlexandre
AlexAlexandre suggested changes Oct 11, 2021
View reviewed changes
app/containers/TextInput.tsx Outdated Show resolved Hide resolved
@AlexAlexandre
Copy link
Contributor

@gerzonc Lint is failing

@gerzonc gerzonc requested a review from AlexAlexandre October 14, 2021 19:31
AlexAlexandre
AlexAlexandre approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@diegolmello diegolmello merged commit 9922fdd into develop Oct 20, 2021
@diegolmello diegolmello deleted the chore.migrate-loginview-ts branch October 20, 2021 17:45
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@gerzonc
Chore: Migrate LoginView to TypeScript (RocketChat#3423)
6ce0d4f 
* Initial commit

* Update interface

* Minor tweaks

* Update FormContainer.tsx

* Minor tweaks

* update snapshots

* Update TextInput interface

* Update snapshots

* Merge branch 'develop' into chore.migrate-loginview-ts

* Minor tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAlexandre AlexAlexandre AlexAlexandre approved these changes

Assignees

@gerzonc gerzonc

Labels
🚚 chore 👀 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerzonc @AlexAlexandre @diegolmello