Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Unnecessary navigation on server forced logout #3428

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

reinaldonetof
Copy link
Contributor

Proposed changes

When the user was forced by the server to log out, there was a rule to move him back to NewServerView changing the root of appStart and after navigate to NewServerView again. But now the first app's screen is the NewServerView. So I just removed the navigation.

Issue(s)

How to test or reproduce

  • Do a login with the same account on the mobile app and on the web app
  • Inside the web app, go to My account and click on Logout From Other Logged In Locations
  • Now in the mobile app, you need to reopen the app, and you will be log out and moved to the first screen of the app

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello changed the title [FIX] Review the logout flow [FIX] Unnecessary navigation on server forced logout Oct 7, 2021
@diegolmello diegolmello merged commit 2d39242 into develop Oct 14, 2021
@diegolmello diegolmello deleted the fix.review-logout branch October 14, 2021 19:38
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants