Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Migrate NewServerView to Typescript #3431

Merged
merged 12 commits into from
Oct 20, 2021
Merged

Chore: Migrate NewServerView to Typescript #3431

merged 12 commits into from
Oct 20, 2021

Conversation

reinaldonetof
Copy link
Contributor

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Oct 6, 2021
@lgtm-com
Copy link

lgtm-com bot commented Oct 6, 2021

This pull request introduces 3 alerts and fixes 3 when merging f648a39 into aba0e49 - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2021

This pull request introduces 2 alerts and fixes 3 when merging fa5ff1e into 8af82df - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2021

This pull request introduces 2 alerts and fixes 3 when merging 37ddee1 into 8af82df - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2021

This pull request introduces 2 alerts and fixes 3 when merging 0511aab into 8af82df - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2021

This pull request introduces 2 alerts and fixes 3 when merging e5a60d3 into 8af82df - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

@lgtm-com
Copy link

lgtm-com bot commented Oct 11, 2021

This pull request introduces 2 alerts and fixes 3 when merging e5ed7c6 into 8af82df - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

@lgtm-com
Copy link

lgtm-com bot commented Oct 11, 2021

This pull request introduces 2 alerts and fixes 3 when merging 185e69d into 8af82df - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

AlexAlexandre
AlexAlexandre suggested changes Oct 11, 2021
View reviewed changes
app/views/NewServerView/index.tsx Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2021

This pull request introduces 2 alerts and fixes 3 when merging 125c343 into 8af82df - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2021

This pull request introduces 2 alerts and fixes 3 when merging 8b6ba19 into 2d39242 - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

AlexAlexandre
AlexAlexandre approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 2 alerts and fixes 3 when merging 270c011 into 467a1a5 - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

@diegolmello diegolmello merged commit 27db881 into develop Oct 20, 2021
@diegolmello diegolmello deleted the chore.ts-newserverview branch October 20, 2021 18:04
@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 2 alerts and fixes 3 when merging 7a70fcb into 744893f - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

fixed alerts:

  • 2 for Inefficient regular expression
  • 1 for Potentially inconsistent state update

ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof @AlexAlexandre
Chore: Migrate NewServerView to Typescript (RocketChat#3431)
3301c0b 
* Chore: Migrate NewServerView to Typescript

* fix one alert lgtm

* Item.tsx

* export interface and try to rewrite write instead action

* minor tweak

* minor tweak

* refactor: change the type of username to connectServer

* refactor scaling

* minor tweak

Co-authored-by: AlexAlexandre <alexalexandrejr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAlexandre AlexAlexandre AlexAlexandre approved these changes

Assignees

@reinaldonetof reinaldonetof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reinaldonetof @AlexAlexandre @diegolmello