Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Markdown not rendering as preview for threaded messages #3465

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

diegolmello
Copy link
Member

Proposed changes

Threaded messages shouldn't render all markdown the rules, like mention or links.

Issue(s)

How to test or reproduce

This is how the web does it:

Before After

There are a few known issues on the screenshot, like not parsing mentions and not rendering custom emojis.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello merged commit e0a0a31 into develop Oct 27, 2021
@diegolmello diegolmello deleted the fix.md-preview-older branch October 27, 2021 13:09
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant