Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Migrate AddExistingChannelView to Typescript #3474

Merged
merged 5 commits into from
Nov 10, 2021

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Oct 29, 2021

Proposed changes

Issue(s)

How to test or reproduce

  • Create a Team, then click on "edit/create" icon on the header, and the new header title should be Add Channel to Team, so you need to click on Add Existing
  • Then check if is working properly the query, search, and other functions.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

app/views/AddExistingChannelView.tsx Outdated Show resolved Hide resolved
app/views/AddExistingChannelView.tsx Outdated Show resolved Hide resolved
app/views/AddExistingChannelView.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@diegolmello diegolmello merged commit 8b4e39d into develop Nov 10, 2021
@diegolmello diegolmello deleted the chore.ts-addexistingchannelview branch November 10, 2021 20:41
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants