Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Migrate redux module server to TypeScript #3627

Merged
merged 18 commits into from
Feb 1, 2022
Merged

Chore: Migrate redux module server to TypeScript #3627

merged 18 commits into from
Feb 1, 2022

Conversation

gerzonc
Copy link
Contributor

@gerzonc gerzonc commented Jan 18, 2022 •
edited
Loading

Proposed changes

Migrate redux module server to TypeScript

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@gerzonc gerzonc self-assigned this Jan 18, 2022
@gerzonc gerzonc changed the title Chore: Migrate redux server action/reducer to TS Chore: Migrate redux module server to TS Jan 18, 2022
@gerzonc gerzonc marked this pull request as ready for review January 20, 2022 15:06
diegolmello
diegolmello requested changes Jan 20, 2022
View reviewed changes
app/reducers/server.ts Outdated Show resolved Hide resolved
@gerzonc gerzonc changed the title Chore: Migrate redux module server to TS Chore: Migrate redux module server to TypeScript Feb 1, 2022
@gerzonc gerzonc merged commit 9773fc1 into develop Feb 1, 2022
@gerzonc gerzonc deleted the chore.migrate-redux-server-to-ts branch February 1, 2022 15:41
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@gerzonc
Merge pull request RocketChat#3627 from RocketChat/chore.migrate-redu…
018684c 
…x-server-to-ts

Chore: Migrate redux module server to TypeScript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees

@gerzonc gerzonc

Labels
🚚 chore 👀 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerzonc @diegolmello