This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Allow replying in notification (Quick Reply) #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 30, 2017
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)
cardoso
changed the title
|
I wanted to also quote the message like we do when replying from inside the App, but for now we are blocked by RocketChat/Rocket.Chat#8996. No big deal I guess. |
… into feat/notification_reply.831
Codecov Report
@@ Coverage Diff @@
## develop #1023 +/- ##
===========================================
+ Coverage 38.23% 38.46% +0.23%
===========================================
Files 220 220
Lines 13051 13094 +43
Branches 691 695 +4
===========================================
+ Hits 4990 5037 +47
+ Misses 7611 7608 -3
+ Partials 450 449 -1
Continue to review full report at Codecov.
|
cardoso
changed the title
|
Looking very very good! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Description
This feature allows the user to reply to a message from a notification without having to enter the App. (iOS 10 capability)
Will only work in Rocket.Chat servers with 0.60.0 or above.
Here's an instance for testing: https://unstable.rocket.chat
Closes #831
Preview
Progress