This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Send messages via HTTP + WebSockets fallback #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 7, 2017
| extension APIResult where T == SendMessageRequest { | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)
Codecov Report
@@ Coverage Diff @@
## develop #1053 +/- ##
===========================================
+ Coverage 43.39% 44.95% +1.56%
===========================================
Files 246 243 -3
Lines 13938 13688 -250
Branches 770 770
===========================================
+ Hits 6048 6154 +106
+ Misses 7425 7077 -348
+ Partials 465 457 -8
Continue to review full report at Codecov.
|
cardoso
changed the title
rafaelks
reviewed
Dec 7, 2017
| case .version: | ||
| // old server version: fallback to web sockets | ||
| SubscriptionManager.sendTextMessage(message, completion: { response in | ||
| updateMessage(json: response.result["result"]) |
houndci-bot
reviewed
Dec 7, 2017
| }, errored: { error in | ||
| switch error { | ||
| case .version: | ||
| // TODO: Remove SendMessage Fallback + old methods after Rocket.Chat 1.0 |
There was a problem hiding this comment.
Todo Violation: TODOs should be avoided (Remove SendMessage Fallback + ...). (todo)
houndci-bot
reviewed
Dec 7, 2017
| }, errored: { error in | ||
| switch error { | ||
| case .version: | ||
| // TODO: Remove SendMessage Fallback + old methods after Rocket.Chat 1.0 |
There was a problem hiding this comment.
Todo Violation: TODOs should be avoided (Remove SendMessage Fallback + ...). (todo)
rafaelks
approved these changes
Dec 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Testable on: https://unstable.rocket.chat
Closes #830
Closes #473
TODO