This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Send messages via REST API #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 14, 2017
| }) | ||
| } | ||
| // TODO: Immediate feedback | ||
| SubscriptionManager.sendTextMessage(message) { result in |
There was a problem hiding this comment.
Unused Closure Parameter Violation: Unused parameter "result" in a closure should be replaced with _. (unused_closure_parameter)
| } | ||
| // TODO: Immediate feedback | ||
| SubscriptionManager.sendTextMessage(message) { result in | ||
| // TODO: Update message |
There was a problem hiding this comment.
Todo Violation: TODOs should be avoided (Update message). (todo)
| MessageTextCacheManager.shared.update(for: message, completion: nil) | ||
| }) | ||
| } | ||
| // TODO: Immediate feedback |
There was a problem hiding this comment.
Todo Violation: TODOs should be avoided (Immediate feedback). (todo)
Codecov Report
@@ Coverage Diff @@
## develop #958 +/- ##
===========================================
- Coverage 17.9% 16.86% -1.04%
===========================================
Files 159 160 +1
Lines 7735 7748 +13
===========================================
- Hits 1385 1307 -78
- Misses 6350 6441 +91 |
cardoso
force-pushed
the
new/send_rest.830
branch
3 times, most recently
from
c173332 to
2a42dd2
Compare
cardoso
force-pushed
the
new/send_rest.830
branch
from
2a42dd2 to
0f88576
Compare
cardoso
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Description
This PR adds the REST API abstraction for sending messages
Progress