Do not require params on client

RocketChat · Jan 11, 2024 · 00a0092 · 00a0092
1 parent f223e70
commit 00a0092
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/apps/meteor/client/views/admin/settings/inputs/ActionSettingInput.tsx b/apps/meteor/client/views/admin/settings/inputs/ActionSettingInput.tsx
@@ -19,9 +19,10 @@ function ActionSettingInput({ _id, actionText, value, disabled, sectionChanged }
 
 	const handleClick = async (): Promise<void> => {
 		try {
-			const data: { message: TranslationKey; params: string[] } = await actionMethod();
+			const data: { message: TranslationKey; params?: string[] } = await actionMethod();
 
-			dispatchToastMessage({ type: 'success', message: t(data.message, ...data.params) });
+			const params = data.params || [];
+			dispatchToastMessage({ type: 'success', message: t(data.message, ...params) });
 		} catch (error) {
 			dispatchToastMessage({ type: 'error', message: error });
 		}

diff --git a/apps/meteor/server/methods/OEmbedCacheCleanup.ts b/apps/meteor/server/methods/OEmbedCacheCleanup.ts
@@ -8,7 +8,7 @@ import { settings } from '../../app/settings/server';
 declare module '@rocket.chat/ui-contexts' {
 	// eslint-disable-next-line @typescript-eslint/naming-convention
 	interface ServerMethods {
-		OEmbedCacheCleanup(): { message: string; params: unknown[] };
+		OEmbedCacheCleanup(): { message: string };
 	}
 }
 
@@ -31,7 +31,6 @@ Meteor.methods<ServerMethods>({
 		await executeClearOEmbedCache();
 		return {
 			message: 'cache_cleared',
-			params: [],
 		};
 	},
 });