Chore: Fix some settings with incompatible default value types (#26114)

RocketChat · Aug 26, 2022 · 0d2e2b1 · 0d2e2b1
1 parent 768d59d
commit 0d2e2b1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/apps/meteor/app/cas/server/cas_rocketchat.js b/apps/meteor/app/cas/server/cas_rocketchat.js
@@ -36,8 +36,8 @@ Meteor.startup(function () {
 		});
 
 		this.section('CAS_Login_Layout', function () {
-			this.add('CAS_popup_width', '810', { type: 'int', group: 'CAS', public: true });
-			this.add('CAS_popup_height', '610', { type: 'int', group: 'CAS', public: true });
+			this.add('CAS_popup_width', 810, { type: 'int', group: 'CAS', public: true });
+			this.add('CAS_popup_height', 610, { type: 'int', group: 'CAS', public: true });
 			this.add('CAS_button_label_text', 'CAS', { type: 'string', group: 'CAS' });
 			this.add('CAS_button_label_color', '#FFFFFF', { type: 'color', group: 'CAS' });
 			this.add('CAS_button_color', '#1d74f5', { type: 'color', group: 'CAS' });

diff --git a/apps/meteor/app/meteor-accounts-saml/server/lib/settings.ts b/apps/meteor/app/meteor-accounts-saml/server/lib/settings.ts
@@ -278,7 +278,7 @@ export const addSettings = function (name: string): void {
 						i18nDescription: 'SAML_Default_User_Role_Description',
 					});
 
-					this.add(`SAML_Custom_${name}_allowed_clock_drift`, false, {
+					this.add(`SAML_Custom_${name}_allowed_clock_drift`, 0, {
 						type: 'int',
 						invalidValue: 0,
 						i18nLabel: 'SAML_Allowed_Clock_Drift',

diff --git a/apps/meteor/server/settings/ldap.ts b/apps/meteor/server/settings/ldap.ts
@@ -19,7 +19,7 @@ settingsRegistry.addGroup('LDAP', function () {
 		});
 
 		this.add('LDAP_Host', '', { type: 'string', enableQuery });
-		this.add('LDAP_Port', '389', { type: 'int', enableQuery });
+		this.add('LDAP_Port', 389, { type: 'int', enableQuery });
 		this.add('LDAP_Reconnect', false, { type: 'boolean', enableQuery });
 
 		this.add('LDAP_Login_Fallback', false, { type: 'boolean', enableQuery });