fix: recurring ENOENT errors when processing export requests (#30063)

* fix: unable to create user if user manual approval is enabled

* don't create directories when scheduling, create them when actually
running

* come on

* oops

* sorry

* add changeset

* oh you linter

.changeset/swift-walls-protect.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixed failing user data exports

apps/meteor/server/lib/dataExport/processDataDownloads.ts

@@ -49,6 +49,8 @@ const generateUserFile = async (exportOperation: IExportOperation, userData?: IU
 		return;
 	}
 
+	await mkdir(exportOperation.exportPath, { recursive: true });
+
 	const { username, name, statusText, emails, roles, services } = userData;
 
 	const dataToSave = {
@@ -101,6 +103,8 @@ const generateUserAvatarFile = async (exportOperation: IExportOperation, userDat
 		return;
 	}
 
+	await mkdir(exportOperation.exportPath, { recursive: true });
+
 	const file = await Avatars.findOneByName(userData.username);
 	if (!file) {
 		return;
@@ -117,6 +121,8 @@ const generateChannelsFile = async (type: 'json' | 'html', exportPath: string, e
 		return;
 	}
 
+	await mkdir(exportOperation.exportPath, { recursive: true });
+
 	const fileName = joinPath(exportPath, 'channels.json');
 	await writeFile(
 		fileName,

apps/meteor/server/methods/requestDataDownload.ts

@@ -1,4 +1,4 @@
-import { mkdir, mkdtemp } from 'fs/promises';
+import { mkdtemp } from 'fs/promises';
 import { tmpdir } from 'os';
 import path, { join } from 'path';
 
@@ -65,7 +65,6 @@ Meteor.methods<ServerMethods>({
 		}
 
 		const tempFolder = settings.get<string | undefined>('UserData_FileSystemPath')?.trim() || (await mkdtemp(join(tmpdir(), 'userData')));
-		await mkdir(tempFolder, { recursive: true });
 
 		const exportOperation = {
 			status: 'preparing',
@@ -81,10 +80,8 @@ Meteor.methods<ServerMethods>({
 		exportOperation._id = id;
 
 		const folderName = path.join(tempFolder, id);
-		await mkdir(folderName, { recursive: true });
 
 		const assetsFolder = path.join(folderName, 'assets');
-		await mkdir(assetsFolder, { recursive: true });
 
 		exportOperation.exportPath = folderName;
 		exportOperation.assetsPath = assetsFolder;