[NEW] Warn admins about running multiple instances of the monolith (#…

…26667) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
RocketChat · Aug 26, 2022 · 3fdf9b3 · 3fdf9b3
1 parent 04b918a
commit 3fdf9b3
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 3 deletions.
diff --git a/apps/meteor/client/views/admin/info/InformationPage.tsx b/apps/meteor/client/views/admin/info/InformationPage.tsx
@@ -33,7 +33,8 @@ const InformationPage = memo(function InformationPage({
 		return null;
 	}
 
-	const alertOplogForMultipleInstances = statistics && statistics.instanceCount > 1 && !statistics.oplogEnabled;
+	const usingMultipleInstances = statistics?.instanceCount > 1;
+	const alertOplogForMultipleInstances = usingMultipleInstances && !statistics.oplogEnabled;
 
 	return (
 		<Page data-qa='admin-info'>
@@ -52,6 +53,7 @@ const InformationPage = memo(function InformationPage({
 
 			<Page.ScrollableContentWithShadow>
 				<Box marginBlock='none' marginInline='auto' width='full'>
+					{usingMultipleInstances && <Callout type='danger' title={t('Multiple_monolith_instances_alert')} marginBlockEnd='x16'></Callout>}
 					{alertOplogForMultipleInstances && (
 						<Callout
 							type='danger'

diff --git a/apps/meteor/definition/externals/meteor/konecty-multiple-instances-status.d.ts b/apps/meteor/definition/externals/meteor/konecty-multiple-instances-status.d.ts
@@ -1,5 +1,7 @@
 declare module 'meteor/konecty:multiple-instances-status' {
 	namespace InstanceStatus {
 		function id(): string;
+
+		function registerInstance(name: string, instance: Record<string, unknown>): void;
 	}
 }
diff --git a/apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json b/apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
@@ -3305,6 +3305,7 @@
   "Msgs": "Msgs",
   "multi": "multi",
   "multi_line": "multi line",
+  "Multiple_monolith_instances_alert": "You are operating multiple instances... some features will not behave as designed.",
   "Mute": "Mute",
   "Mute_and_dismiss": "Mute and dismiss",
   "Mute_all_notifications": "Mute all notifications",

diff --git a/apps/meteor/server/models/raw/InstanceStatus.ts b/apps/meteor/server/models/raw/InstanceStatus.ts
@@ -13,4 +13,8 @@ export class InstanceStatusRaw extends BaseRaw<IInstanceStatus> implements IInst
 			},
 		});
 	}
+
+	async getActiveInstanceCount(): Promise<number> {
+		return this.col.countDocuments({ _updatedAt: { $gt: new Date(Date.now() - process.uptime() * 1000 - 2000) } });
+	}
 }
diff --git a/apps/meteor/server/startup/instance.js → apps/meteor/server/startup/instance.ts b/apps/meteor/server/startup/instance.js → apps/meteor/server/startup/instance.ts
@@ -2,8 +2,13 @@ import os from 'os';
 
 import { Meteor } from 'meteor/meteor';
 import { InstanceStatus } from 'meteor/konecty:multiple-instances-status';
+import { TAPi18n } from 'meteor/rocketchat:tap-i18n';
+import { InstanceStatus as InstanceStatusRaw } from '@rocket.chat/models';
 
 import { startStreamBroadcast } from '../stream/streamBroadcast';
+import { Logger } from '../lib/logger/Logger';
+
+const logger = new Logger('InstanceStartup');
 
 Meteor.startup(function () {
 	const instance = {
@@ -25,5 +30,9 @@ Meteor.startup(function () {
 
 	InstanceStatus.registerInstance('rocket.chat', instance);
 
+	if (Promise.await(InstanceStatusRaw.getActiveInstanceCount()) > 1) {
+		logger.warn(TAPi18n.__('Multiple_monolith_instances_alert'));
+	}
+
 	return startStreamBroadcast();
 });
diff --git a/apps/meteor/server/stream/streamBroadcast.js b/apps/meteor/server/stream/streamBroadcast.js
@@ -4,6 +4,7 @@ import { InstanceStatus } from 'meteor/konecty:multiple-instances-status';
 import { check } from 'meteor/check';
 import { DDP } from 'meteor/ddp';
 import { InstanceStatus as InstanceStatusRaw } from '@rocket.chat/models';
+import { TAPi18n } from 'meteor/rocketchat:tap-i18n';
 
 import { Logger } from '../lib/logger/Logger';
 import { hasPermission } from '../../app/authorization/server';
@@ -67,6 +68,10 @@ function startMatrixBroadcast() {
 		added: Meteor.bindEnvironment((record) => {
 			cache.set(record._id, record);
 
+			if (cache.size() > 1) {
+				logger.warn(TAPi18n.__('Multiple_monolith_instances_alert'));
+			}
+
 			const subPath = getURL('', { cdn: false, full: false });
 			let instance = `${record.extraInformation.host}:${record.extraInformation.port}${subPath}`;
 

diff --git a/packages/model-typings/src/models/IInstanceStatusModel.ts b/packages/model-typings/src/models/IInstanceStatusModel.ts
@@ -2,7 +2,6 @@ import type { IInstanceStatus } from '@rocket.chat/core-typings';
 
 import type { IBaseModel } from './IBaseModel';
 
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface IInstanceStatusModel extends IBaseModel<IInstanceStatus> {
-	//
+	getActiveInstanceCount(): Promise<number>;
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     			},
     		});
     	}
+    	async getActiveInstanceCount(): Promise<number> {
+    		return this.col.countDocuments({ _updatedAt: { $gt: new Date(Date.now() - process.uptime() * 1000 - 2000) } });
+    	}
     }