chore: improve readability on unverifyContactChannel

RocketChat · Oct 14, 2024 · 81020db · 81020db
1 parent c77655e
commit 81020db
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/apps/meteor/app/livechat/server/lib/Contacts.ts b/apps/meteor/app/livechat/server/lib/Contacts.ts
@@ -350,13 +350,17 @@ export async function unverifyContactChannel(
 	channelName: string,
 	visitorId: string,
 ): Promise<ILivechatContact> {
-	const channelToUnverify = contact.channels?.find((channel) => channel.name === channelName && channel.visitorId === visitorId);
+	if (!contact.channels) {
+		throw new Error('error-invalid-channel');
+	}
 
-	if (!channelToUnverify) {
+	const channelToUnverify = contact.channels.findIndex((channel) => channel.name === channelName && channel.visitorId === visitorId);
+	if (channelToUnverify < 0) {
 		throw new Error('error-invalid-channel');
 	}
 
-	channelToUnverify.verified = false;
+	contact.channels[channelToUnverify].verified = false;
+
 	return LivechatContacts.updateContact(contact._id, {
 		channels: contact.channels,
 	});