Skip to content

Commit

Permalink
[FIX] Apps-Engine's scheduler failing to update run tasks (#22882)
Browse files Browse the repository at this point in the history
Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
  • Loading branch information
2 people authored and sampaiodiego committed Aug 16, 2021
1 parent 00f82fe commit a0e4c7d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 14 deletions.
8 changes: 4 additions & 4 deletions app/apps/server/bridges/scheduler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ function _callProcessor(processor: Function): (job: { attrs?: { data: object } }
// This field is for internal use, no need to leak to app processor
delete (data as any).appId;

processor(data);
return processor(data);
};
}

/**
* Provides the Apps Engine with task scheduling capabilities
* Provides the Apps Engine with task scheduling capabilities.
* It uses {@link agenda:github.com/agenda/agenda} as backend
*/
export class AppSchedulerBridge extends SchedulerBridge {
Expand All @@ -43,7 +43,7 @@ export class AppSchedulerBridge extends SchedulerBridge {
}

/**
* Entity that will be run in a job
* Entity that will be run in a job.
* @typedef {Object} Processor
* @property {string} id The processor's identifier
* @property {function} processor The function that will be run on a given schedule
Expand Down Expand Up @@ -127,7 +127,7 @@ export class AppSchedulerBridge extends SchedulerBridge {
}

/**
* Schedules a registered processor to run recurrently according to a given interval
* Schedules a registered processor to run recurrently according to a given interval.
*
* @param {Object} job
* @param {string} job.id The processor's id
Expand Down
17 changes: 8 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@
"@slack/client": "^4.12.0",
"@types/lodash": "^4.14.171",
"adm-zip": "0.4.14",
"agenda": "^3.1.0",
"agenda": "github:RocketChat/agenda#3.1.2",
"apn": "2.2.0",
"archiver": "^3.1.1",
"arraybuffer-to-string": "^1.0.2",
Expand Down

0 comments on commit a0e4c7d

Please sign in to comment.