[FIX] cachedcollection calling multiple times SYNC (#15104)

* fixed cachedcollection calling multiple times * fix tests * fix review
RocketChat · Aug 6, 2019 · b9a9a3f · b9a9a3f
1 parent 8571128
commit b9a9a3f
Show file tree

Hide file tree

Showing 4 changed files with 197 additions and 229 deletions.
diff --git a/app/models/server/models/Settings.js b/app/models/server/models/Settings.js
@@ -55,7 +55,7 @@ export class Settings extends Base {
 		};
 
 		if (ids.length > 0) {
-			filter._id =				{ $in: ids };
+			filter._id = { $in: ids };
 		}
 
 		return this.find(filter, { fields: { _id: 1, value: 1 } });

diff --git a/app/settings/client/lib/settings.js b/app/settings/client/lib/settings.js
@@ -13,8 +13,6 @@ settings.cachedCollection = new CachedCollection({
 
 settings.collection = settings.cachedCollection.collection;
 
-settings.cachedCollection.init();
-
 settings.dict = new ReactiveDict('settings');
 
 settings.get = function(_id) {