Chore: Room access validation may be called without user information (#…

…26086)

apps/meteor/app/livechat/server/roomAccessValidator.internalService.ts

@@ -9,7 +9,7 @@ export class AuthorizationLivechat extends ServiceClassInternal implements IAuth
 
 	protected internal = true;
 
-	async canAccessRoom(room: IOmnichannelRoom, user: Pick<IUser, '_id'>, extraData?: object): Promise<boolean> {
+	async canAccessRoom(room: IOmnichannelRoom, user?: Pick<IUser, '_id'>, extraData?: object): Promise<boolean> {
 		for (const validator of validators) {
 			if (validator(room, user, extraData)) {
 				return true;

apps/meteor/server/sdk/types/IAuthorization.ts

@@ -2,7 +2,7 @@ import type { IRoom, IUser } from '@rocket.chat/core-typings';
 
 export type RoomAccessValidator = (
 	room: Pick<IRoom, '_id' | 't' | 'teamId' | 'prid'>,
-	user: Pick<IUser, '_id'>,
+	user?: Pick<IUser, '_id'>,
 	extraData?: Record<string, any>,
 ) => Promise<boolean>;
 
@@ -11,5 +11,5 @@ export interface IAuthorization {
 	hasPermission(userId: string, permissionId: string, scope?: string): Promise<boolean>;
 	hasAtLeastOnePermission(userId: string, permissions: string[], scope?: string): Promise<boolean>;
 	canAccessRoom: RoomAccessValidator;
-	canAccessRoomId(rid: IRoom['_id'], uid: IUser['_id']): Promise<boolean>;
+	canAccessRoomId(rid: IRoom['_id'], uid?: IUser['_id']): Promise<boolean>;
 }

apps/meteor/server/sdk/types/IAuthorizationLivechat.ts

@@ -1,5 +1,5 @@
 import type { IOmnichannelRoom, IUser } from '@rocket.chat/core-typings';
 
 export interface IAuthorizationLivechat {
-	canAccessRoom: (room: IOmnichannelRoom, user: Pick<IUser, '_id'>, extraData?: Record<string, any>) => Promise<boolean>;
+	canAccessRoom: (room: IOmnichannelRoom, user?: Pick<IUser, '_id'>, extraData?: Record<string, any>) => Promise<boolean>;
 }

apps/meteor/server/services/authorization/canAccessRoom.ts

@@ -7,7 +7,7 @@ import { RoomAccessValidator } from '../../sdk/types/IAuthorization';
 import { canAccessRoomLivechat } from './canAccessRoomLivechat';
 import { canAccessRoomVoip } from './canAccessRoomVoip';
 
-async function canAccessPublicRoom(user: Partial<IUser>): Promise<boolean> {
+async function canAccessPublicRoom(user?: Partial<IUser>): Promise<boolean> {
 	if (!user?._id) {
 		// TODO: it was using cached version from /app/settings/server/raw.js
 		const anon = await Settings.getValueById('Accounts_AllowAnonymousRead');