Await promise to handle error when attempting to transfer a room (#23739

)
RocketChat · Nov 18, 2021 · bc91e46 · bc91e46
1 parent c54ef38
commit bc91e46
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/app/livechat/server/lib/Livechat.js b/app/livechat/server/lib/Livechat.js
@@ -598,7 +598,7 @@ export const Livechat = {
 			const user = Users.findOneById(userId);
 			const { _id, username, name } = user;
 			const transferredBy = normalizeTransferredByData({ _id, username, name }, room);
-			this.transfer(room, guest, { roomId: room._id, transferredBy, departmentId: guest.department });
+			Promise.await(this.transfer(room, guest, { roomId: room._id, transferredBy, departmentId: guest.department }));
 		});
 	},
 

diff --git a/app/livechat/server/lib/stream/agentStatus.ts b/app/livechat/server/lib/stream/agentStatus.ts
@@ -2,6 +2,9 @@ import { Meteor } from 'meteor/meteor';
 
 import { Livechat } from '../Livechat';
 import { settings } from '../../../../settings/server';
+import { Logger } from '../../../../logger/server';
+
+const logger = new Logger('AgentStatusWatcher');
 
 export let monitorAgents = false;
 let actionTimeout = 60000;
@@ -64,12 +67,19 @@ export const onlineAgents = {
 		onlineAgents.users.delete(userId);
 		onlineAgents.queue.delete(userId);
 
-		if (action === 'close') {
-			return Livechat.closeOpenChats(userId, comment);
-		}
+		try {
+			if (action === 'close') {
+				return Livechat.closeOpenChats(userId, comment);
+			}
 
-		if (action === 'forward') {
-			return Livechat.forwardOpenChats(userId);
+			if (action === 'forward') {
+				return Livechat.forwardOpenChats(userId);
+			}
+		} catch (e) {
+			logger.error({
+				msg: `Cannot perform action ${ action }`,
+				err: e,
+			});
 		}
 	}),
 };