added delete channel button (#10438)

[FIX] Button to delete rooms by the owners wasn't appearing
RocketChat · Apr 16, 2018 · c9c0d8d · c9c0d8d
1 parent f6a08e6
commit c9c0d8d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/packages/rocketchat-channel-settings/client/views/channelSettings.html b/packages/rocketchat-channel-settings/client/views/channelSettings.html
@@ -245,8 +245,8 @@ <h3 title="{{name}}" class="rc-user-info__name">{{> icon block="rc-header__icon"
 		{{#if canLeaveRoom}}
 		<button class="rc-button rc-button--icon rc-button--outline rc-button--cancel js-leave">{{> icon icon='sign-out'}}{{_ 'Leave'}}</button>
 		{{/if}}
-		<!-- {{#if canDeleteRoom}}
-		<button class="rc-button rc-button-outline rc-button-cancel js-delete" title="{{_ 'Delete'}}">{{> icon icon='trash'}}{{_ 'Delete'}}</button>
-		{{/if}} -->
 	</div>
+	{{#if canDeleteRoom}}
+	<button class="rc-button rc-button-outline rc-button-cancel js-delete rc-button--cancel rc-button--stack" title="{{_ 'Delete'}}">{{> icon icon='trash'}}{{_ 'Delete'}}</button>
+	{{/if}}
 </template>
diff --git a/packages/rocketchat-channel-settings/client/views/channelSettings.js b/packages/rocketchat-channel-settings/client/views/channelSettings.js
@@ -14,7 +14,7 @@ const common = {
 		});
 
 		const roomType = room && room.t;
-		return roomType && RocketChat.roomTypes.roomTypes[room.t].canBeDeleted(room);
+		return roomType && RocketChat.roomTypes.roomTypes[roomType].canBeDeleted(room);
 	},
 	canEditRoom() {
 		const { _id } = Template.instance().room;

diff --git a/packages/rocketchat-theme/client/imports/forms/button.css b/packages/rocketchat-theme/client/imports/forms/button.css
@@ -4,7 +4,11 @@
 	}
 
 	&--icon > svg {
-		margin: 0 5px;
+		margin: 0 5px 0 -5px;
+
+		.rtl & {
+			margin: 0 -5px 0 5px;
+		}
 
 		font-size: 20px;
 		fill: currentColor;
@@ -107,6 +111,9 @@
 		border-style: solid;
 		background: transparent;
 	}
+	&--stack {
+		width: 100%;
+	}
 
 	&.loading {
 		position: relative;