[FIX] Updating an app via "Update" button errors out with "App alread…

…y exists" (#15814)
RocketChat · Nov 19, 2019 · d688522 · d688522
1 parent 2289486
commit d688522
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/app/apps/client/admin/appManage.js b/app/apps/client/admin/appManage.js
@@ -398,7 +398,7 @@ Template.appManage.events({
 		_app.set('working', true);
 
 		try {
-			const { status } = await Apps.installApp(appId, _app.get('marketplaceVersion'));
+			const { status } = await Apps.updateApp(appId, _app.get('marketplaceVersion'));
 			warnStatusChange(_app.get('name'), status);
 		} catch (error) {
 			handleAPIError(error);

diff --git a/app/apps/client/admin/helpers.js b/app/apps/client/admin/helpers.js
@@ -277,8 +277,7 @@ export const appButtonProps = ({
 }) => {
 	const canUpdate = installed
 		&& version && marketplaceVersion
-		&& semver.lt(version, marketplaceVersion)
-		&& isPurchased;
+		&& semver.lt(version, marketplaceVersion);
 	if (canUpdate) {
 		return {
 			action: 'update',

diff --git a/app/apps/client/orchestrator.js b/app/apps/client/orchestrator.js
@@ -145,6 +145,15 @@ class AppClientOrchestrator {
 		return app;
 	}
 
+	updateApp = async (appId, version) => {
+		const { app } = await APIClient.post(`apps/${ appId }`, {
+			appId,
+			marketplace: true,
+			version,
+		});
+		return app;
+	}
+
 	uninstallApp = (appId) => APIClient.delete(`apps/${ appId }`)
 
 	syncApp = (appId) => APIClient.post(`apps/${ appId }/sync`)