fix: Add missing awaits to .count() calls (#29323)

RocketChat · May 23, 2023 · f8cd53b · f8cd53b
1 parent 1687bfb
commit f8cd53b
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 6 deletions.
diff --git a/.changeset/quiet-rules-swim.md b/.changeset/quiet-rules-swim.md
@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+fix: Add missing awaits to .count() calls
diff --git a/apps/meteor/app/importer-pending-avatars/server/importer.js b/apps/meteor/app/importer-pending-avatars/server/importer.js
@@ -9,7 +9,7 @@ export class PendingAvatarImporter extends Base {
 		await super.updateProgress(ProgressStep.PREPARING_STARTED);
 
 		const users = await Users.findAllUsersWithPendingAvatar();
-		const fileCount = users.count();
+		const fileCount = await users.count();
 
 		if (fileCount === 0) {
 			await super.updateProgress(ProgressStep.DONE);

diff --git a/apps/meteor/app/livechat/client/startup/notifyUnreadRooms.js b/apps/meteor/app/livechat/client/startup/notifyUnreadRooms.js
@@ -16,7 +16,7 @@ Meteor.startup(() => {
 			return;
 		}
 
-		const subs = Subscriptions.find({ t: 'l', ls: { $exists: 0 }, open: true }).count();
+		const subs = await Subscriptions.find({ t: 'l', ls: { $exists: 0 }, open: true }).count();
 		if (subs === 0) {
 			audio && audio.pause();
 			return;

diff --git a/apps/meteor/app/livechat/server/lib/Helper.js b/apps/meteor/app/livechat/server/lib/Helper.js
@@ -299,7 +299,7 @@ export const dispatchInquiryQueued = async (inquiry, agent) => {
 		return;
 	}
 
-	logger.debug(`Notifying ${onlineAgents.count()} agents of new inquiry`);
+	logger.debug(`Notifying ${await onlineAgents.count()} agents of new inquiry`);
 	const notificationUserName = v && (v.name || v.username);
 
 	for await (let agent of onlineAgents) {

diff --git a/apps/meteor/app/livechat/server/lib/Livechat.js b/apps/meteor/app/livechat/server/lib/Livechat.js
@@ -78,7 +78,7 @@ export const Livechat = {
 		if (settings.get('Livechat_assign_new_conversation_to_bot')) {
 			Livechat.logger.debug(`Fetching online bot agents for department ${department}`);
 			const botAgents = await Livechat.getBotAgents(department);
-			const onlineBots = botAgents.count();
+			const onlineBots = await botAgents.count();
 			Livechat.logger.debug(`Found ${onlineBots} online`);
 			if (onlineBots > 0) {
 				return true;

diff --git a/apps/meteor/app/slashcommands-inviteall/server/server.ts b/apps/meteor/app/slashcommands-inviteall/server/server.ts
@@ -57,11 +57,11 @@ function inviteAll<T extends string>(type: T): SlashCommand<T>['callback'] {
 		});
 
 		try {
-			const APIsettings = settings.get('API_User_Limit');
+			const APIsettings = settings.get<number>('API_User_Limit');
 			if (!APIsettings) {
 				return;
 			}
-			if (cursor.count() > APIsettings) {
+			if ((await cursor.count()) > APIsettings) {
 				throw new Meteor.Error('error-user-limit-exceeded', 'User Limit Exceeded', {
 					method: 'addAllToRoom',
 				});