WebDAV big file and crash

[moonwolf-github]

Description:

I've recently enabled WebDAV integration (with out Nextcloud) and was trying to send big file (>100MB). Max file size set in rocket is 12MB. After a few minutes server has crashed.

Steps to reproduce:

1. Add WebDAV integration
2. Send big file

Expected behavior:

If file exceeds rocket limit it should not be sended, file should be sended otherwise.

Actual behavior:

Sever crashes.

Server Setup Information:

• Version of Rocket.Chat Server: 0.71.0
• Operating System: Linux CentOS
• Deployment Method: tar
• Number of Running Instances: 1
• DB Replicaset Oplog:
• NodeJS Version: 8.11.3
• MongoDB Version: 3.4.9

Relevant logs:

Jan 18 14:38:03 nemet rocketchat: [8195:0x32a2b10]   239492 ms: Mark-sweep 870.0 (953.8) -> 870.0 (953.8) MB, 1673.6 / 0.1 ms  allocation failure GC in old space requested
Jan 18 14:38:03 nemet rocketchat: [8195:0x32a2b10]   241187 ms: Mark-sweep 870.0 (953.8) -> 870.0 (912.8) MB, 1695.0 / 0.1 ms  last resort GC in old space requested
Jan 18 14:38:03 nemet rocketchat: [8195:0x32a2b10]   242868 ms: Mark-sweep 870.0 (912.8) -> 870.0 (903.8) MB, 1680.4 / 0.1 ms  last resort GC in old space requested
Jan 18 14:38:03 nemet rocketchat: <--- JS stacktrace --->
Jan 18 14:38:03 nemet rocketchat: ==== JS stack trace =========================================
Jan 18 14:38:03 nemet rocketchat: Security context: 0x201aa6ba5879 <JSObject>
Jan 18 14:38:03 nemet rocketchat: 1: /* anonymous */ [/opt/rocketchat/rocket.chat-0.71.0/programs/server/packages/base64.js:~61] [pc=0x1a62238de03e](this=0x2c745028c209 <JSGlobal Object>,elm=93,i=56406920)
Jan 18 14:38:03 nemet rocketchat: 2: arguments adaptor frame: 3->2
Jan 18 14:38:03 nemet rocketchat: 3: forEach(this=0x3f67c39c4c99 <Uint8Array map = 0x145485b02e09>)
Jan 18 14:38:03 nemet rocketchat: 4: encode [/opt/rocketchat/rocket.chat-0.71.0/programs/server/packages/base64.js:61] [bytecode=0x24c57fc1faf9 o...
Jan 18 14:38:03 nemet rocketchat: FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
Jan 18 14:38:03 nemet rocketchat: 1: node::Abort() [/usr/local/bin/node]
Jan 18 14:38:03 nemet rocketchat: 2: 0x8c21ec [/usr/local/bin/node]
Jan 18 14:38:03 nemet rocketchat: 3: v8::Utils::ReportOOMFailure(char const*, bool) [/usr/local/bin/node]
Jan 18 14:38:03 nemet rocketchat: 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [/usr/local/bin/node]
Jan 18 14:38:03 nemet rocketchat: 5: v8::internal::Factory::NewUninitializedFixedArray(int) [/usr/local/bin/node]
Jan 18 14:38:03 nemet rocketchat: 6: 0xd4b133 [/usr/local/bin/node]
Jan 18 14:38:03 nemet rocketchat: 7: v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [/usr/local/bin/node]
Jan 18 14:38:03 nemet rocketchat: 8: 0x1a62232842fd
Jan 18 14:38:03 nemet systemd: rocketchat.service: main process exited, code=killed, status=6/ABRT

[moonwolf-github]

Same for 0.72.1.

[rudesome]

In version 0.74 the webdav conf will be updated