Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Webdav crash #14918

Merged
merged 3 commits into from
Aug 20, 2019
Merged

[FIX] Webdav crash #14918

merged 3 commits into from
Aug 20, 2019

Conversation

MarcosSpessatto
Copy link
Member

Closes #14900
For some reasons the status property is inside the error.response https://github.com/perry-mitchell/webdav-client/blob/master/source/interface/stat.js#L8 🤷‍♂️

Related to #14243 (comment)
Also for some reasons all exceptions coming from the webdav npm package, seems return axios response inside the error object instead the original error itself. Due to that an error is caused by Meteor when trying to parse the response content with the EJSON. EJSON is trying to parse the axios response that is a circular JSON. Maybe related to it: perry-mitchell/webdav-client#159

Maybe related to #13355
Maybe related to #13191

@MarcosSpessatto MarcosSpessatto added this to the 1.3.0 milestone Jul 2, 2019
@MarcosSpessatto MarcosSpessatto requested a review from rodrigok July 2, 2019 21:59
@rudesome
Copy link

rudesome commented Jul 6, 2019

probably also a fix for my problem: #14900

@MarcosSpessatto MarcosSpessatto changed the title Fix webdav crash [WIP]Fix webdav crash Jul 10, 2019
@MarcosSpessatto MarcosSpessatto changed the title [WIP]Fix webdav crash Fix webdav crash Jul 10, 2019
@rudesome
Copy link

@MarcosSpessatto can the webdav fix be in the 1.3.0 release?

@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@sampaiodiego sampaiodiego changed the title Fix webdav crash [FIX] Webdav crash Aug 20, 2019
@sampaiodiego sampaiodiego merged commit 91cc7cb into develop Aug 20, 2019
@sampaiodiego sampaiodiego deleted the fix-webdav-crash branch August 20, 2019 19:55
@sampaiodiego sampaiodiego mentioned this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading to webdav generates an error
3 participants