Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Block user button #13627

Closed
knrt10 opened this issue Mar 6, 2019 · 5 comments
Closed

[IMPROVE] Block user button #13627

knrt10 opened this issue Mar 6, 2019 · 5 comments

Comments

@knrt10
Copy link
Contributor

knrt10 commented Mar 6, 2019

Description:

This is UI/UX related bug. Block User button is a microphone right now, which should not be as far as I think. It would be better if we change the icon.

Steps to reproduce:

  1. Click on any user
  2. Click on user info button on the top right with user icon on it.

Expected behavior:

Expected

Actual behavior:

Actual

Server Setup Information:

  • Version of Rocket.Chat Server: 1.0.0-develop
  • Operating System: MacOS
  • Deployment Method: Local Server
  • Number of Running Instances: 1
  • DB Replicaset Oplog: no
  • NodeJS Version: 8.11.4
  • MongoDB Version: 3.6

Additional context

I will fix this.

@bhardwajaditya
Copy link
Contributor

May I do this?

@knrt10
Copy link
Contributor Author

knrt10 commented Mar 7, 2019

@bharadwajaditya sorry, I already have made changes to my local branch, just need to push. Thanks again

knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Mar 7, 2019
@bhardwajaditya
Copy link
Contributor

You changed the logo in the for loop which will change for all the actions. I corrected that by changing only for block user.

knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Mar 7, 2019
@knrt10
Copy link
Contributor Author

knrt10 commented Mar 7, 2019

@bhardwajaditya Thanks, you are right. But please remember this, when a PR is opened on an issue, you should not open a PR yourself. You would have suggested changes to the old PR. Hope this will help you in the long run. Cheers 👍

@bhardwajaditya
Copy link
Contributor

Sorry, I am new to open source contributions. Will keep this in mind in future. Thanks for your help.

ggazzo pushed a commit that referenced this issue Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants